[FFmpeg-devel] [PATCH] MPEG-PES avoid MP3 misdetection

Michael Niedermayer michaelni
Tue Sep 15 12:40:24 CEST 2009

On Tue, Sep 15, 2009 at 12:04:02PM +0200, Reimar D?ffinger wrote:
> On Tue, Sep 15, 2009 at 11:38:11AM +0200, Michael Niedermayer wrote:
> > On Sun, Sep 13, 2009 at 11:57:12PM +0200, Reimar D?ffinger wrote:
> > > this is one suggestion for fixing issue1383.
> > > There are no really specific reasons for the values chosen, except that
> > > the lower score now matches the ones for the "unclear" mp3 detection,
> > > so we should continue probing if we are not yet sure if we have mp3 or PES.
> > 
> > ok, btw i have some more changes that togeter with this make mpeg pass
> > probetest
> I guess you know how to write good tests, but I feel somewhat
> uncomfortable with looking too much at probetest since it might make
> people write probe functions that need huge probe buffers to detect
> things reliably, leading to poor performance with probing files played
> over network.

patch to test the opposit, namely positiv detection of a single keyframe
is welcome ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090915/8ea04a13/attachment.pgp>

More information about the ffmpeg-devel mailing list