[FFmpeg-devel] [PATCH] configure: make pkgconfig_generate() fills Libs if shared is not set

[Måns Rullgård]

Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> Hi all again!
>
> We know pkgconfig sucks:
> http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/76273/focus=76365
>
> and yet we are lazy / wise / boring enough to eschew ourself another
> world-save and implement something better at the level of the linker.

There are two reasons I haven't done this:

1. I don't have time.
2. It would never be accepted by the autozombies anyway.

> Note: maybe an even better solution would be to make:
> disabled foo
>
> to evaluate to true if foo is different from "no" (for example if it
> has not been defined).

That would break a lot of things.

> diff --git a/configure b/configure
> index 6aa6177..a071b29 100755
> --- a/configure
> +++ b/configure
> @@ -2796,10 +2796,10 @@ includedir=$incdir
>  Name: $name
>  Description: $comment
>  Version: $version
> -Requires: $(disabled shared && echo $requires)
> +Requires: $(enabled shared || echo $requires)
>  Requires.private: $(enabled shared && echo $requires)
>  Conflicts:
> -Libs: -L\${libdir} -l${shortname} $(disabled shared && echo $libs)
> +Libs: -L\${libdir} -l${shortname} $(enabled shared || echo $libs)
>  Libs.private: $(enabled shared && echo $libs)
>  Cflags: -I\${includedir}
>  EOF

Patch OK.

-- 
M?ns Rullg?rd
mans at mansr.com