[FFmpeg-devel] [PATCH] improve DV probe score

Roman V Shaposhnik rvs
Tue Sep 15 21:23:21 CEST 2009

On Tue, 2009-09-15 at 10:36 +0200, Michael Niedermayer wrote:
> > Not sure I remember right, but the checks look only for block_number ==
> > 0 - I guess mostly because that's what we need for read_header, it
> > _might_ make sense to change it for probe - though it means there is a
> > higher probability of a match in random data, so not sure if it is
> > really an improvement...
> maybe you could do something like i did in h261_probe() ?
> besides, if iam not mistaken these byte sequences must be at fixed
> distances so it would just be checking the existence of 9*4 bytes
> for each startcode at fixed locations, that really would make the
> probe pretty hard to trigger on random data

Right. Also, if the code can check for as many locations as there
are segments -- it'll be pretty bulletproof.


More information about the ffmpeg-devel mailing list