[FFmpeg-devel] [PATCH 1/2] Separate per-arch MDCT init from FFT init

Måns Rullgård mans
Wed Sep 16 23:05:54 CEST 2009

M?ns Rullg?rd <mans at mansr.com> writes:

> Loren Merritt <lorenm at u.washington.edu> writes:
>> On Tue, 15 Sep 2009, Mans Rullgard wrote:
>>> +void ff_mdct_init_neon(MDCTContext *s);
>> [...]
>>> +if (ARCH_ARM) ff_mdct_init_arm(s);
>> inconsistent.
> Indeed, thanks.
>> Also, you're depending on the compiler to optimize away if(0), or
>> you'll get a link error. It just so happens that current gcc does,
>> even with -O0, but I wouldn't bet on it everywhere.
> We do that all over the place.

I can replace those with #if...

Any other issues?

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list