[FFmpeg-devel] [PATCH] flush_put_bits_cache
Wed Sep 16 23:26:25 CEST 2009
On Wed, Sep 16, 2009 at 09:37:35PM +0200, Sascha Sommer wrote:
> On Mittwoch, 16. September 2009, Michael Niedermayer wrote:
> > On Wed, Sep 16, 2009 at 03:24:12PM +0200, Sascha Sommer wrote:
> > > Hi,
> > >
> > > On Sonntag, 13. September 2009, Michael Niedermayer wrote:
> > > > On Sat, Aug 29, 2009 at 01:36:45PM +0200, Sascha Sommer wrote:
> > > > > Hi,
> > > > >
> > > > > attached patch adds an alternate way of flushing the put bits buffer.
> > > > > The new function makes it possible to access a put bits buffer till
> > > > > the last bit without loosing the possibility to still append some
> > > > > more bits at the position of the last write.
> > > >
> > > > why do we need 2 such functions with slightly different semantics?
> > >
> > > We don't need both. The new function could be made the default for
> > > flush_put_bits. The old behaviour could be emulated by calling
> > > align_put_bits before flush_put_bits.
> > is any code depending on the old behaviour?
> I don't know the bitstream details for every muxer/parser/decoder that uses
> flush_put_bits, therefore the new function name. Shall I try to come up with
> a list of use cases where this is not obvious?
i thought you could just change the existing and run the regression tests
that would give a approximate awnser
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel