[FFmpeg-devel] [PATCH] force dnxhd encoder to be independent of qsort internals

Michael Kostylev michael.kostylev
Sun Sep 20 10:36:30 CEST 2009


On Sat Sep 19 13:16:51 2009
Reimar D?ffinger wrote:

> this change makes sure there are no equal elements in the data passed to
> qsort, thus making sure the result is independent of implementation
> internals.
> Not benchmarked, but compared to the function call overhead the extra
> code in the comparison function should not hurt that much.
> Regression test references need to be updated, too.
> Tested and at least FreeBSD and Linux give the same results.

Tested on OpenSolaris/i386, the encoding is ok, the decoding fails.

--- /export/home/mik/src/fate/test/tests/rotozoom.regression.ref        Sat Sep 19 15:04:28 2009
+++ tests/data/rotozoom.regression      Sun Sep 20 12:11:58 2009
@@ -158,13 +158,13 @@
 7200000 ./tests/data/a-dv411.dv
 7f9fa421028aabb11eaf4c6513a5a843 *./tests/data/dv.rotozoom.out.yuv
 stddev:   10.09 PSNR: 28.04 bytes:  7603200/  7603200
-2bae05531a24cd6764eefba64db345bc *./tests/data/a-dv50.dv
+9dc6a7036f51da210bdc2092f10642e7 *./tests/data/a-dv50.dv
 14400000 ./tests/data/a-dv50.dv
 af3f2dd5ab62c1a1d98b07d4aeb6852f *./tests/data/dv50.rotozoom.out.yuv
 stddev:    0.82 PSNR: 49.81 bytes:  7603200/  7603200
-981a11fcd1f5419facc016a7608b3df9 *./tests/data/a-dnxhd-1080i.mov
+308a32e30d6a0cafc79ba7924f6fd37e *./tests/data/a-dnxhd-1080i.mov
 30311415 ./tests/data/a-dnxhd-1080i.mov
-a0119aa04a86c80d6dfd0776c9ece580 *./tests/data/dnxhd.rotozoom.out.yuv
+0a80953377dd83ce00b6bb9b9bc37e02 *./tests/data/dnxhd.rotozoom.out.yuv
 stddev:    1.53 PSNR: 44.37 bytes:  7603200/  7603200
 1ab8a3f04bde27c33e92fe110892e2cd *./tests/data/a-dnxhd-720p.dnxhd
 22937600 ./tests/data/a-dnxhd-720p.dnxhd
gmake: *** [codectest] Error 1

Michael



More information about the ffmpeg-devel mailing list