[FFmpeg-devel] [PATCH] hook up the atrac1 decoder

Benjamin Larsson banan
Tue Sep 22 12:13:58 CEST 2009

Vitor Sessak wrote:
>>> I think a good deal of code of both branches of the if() can be
>>> factorized out.
>> What code? IMO not much of the code in the 2 cases can be factored out
>> and still be logical and clear.
> The calls to at1_imdct() and vector_fmul_window() are very similar. 
> They are exactly the same if block_size == 32 and nbits == 5 when 
> num_blocks == 1. Note also that the for() loop of the else{} branch 
> will be run only once when num_blocks == 1, as it should. Of course, 
> there will always be a if() for the memcpy().

Ok, I see how it could be factored. But the logic of passing parameters 
would be highly obfuscated. And it wouldn't be any faster, I prefer to 
keep the code as it is right now.

Benjamin Larsson

More information about the ffmpeg-devel mailing list