[FFmpeg-devel] [PATCH] vc1: fix ff_msmp4_mb_i_table initialization
Thu Sep 24 12:51:43 CEST 2009
On Thu, Sep 24, 2009 at 01:22:45PM +0300, Kostya wrote:
> On Thu, Sep 24, 2009 at 11:35:14AM +0200, Reimar D?ffinger wrote:
> > Hello,
> > static vlc tables can't really be properly initialized from two places
> > (besides it being code duplication).
> > I suggest to just call ff_msmpeg4_decode_init instead, but if that
> > really is considered too heavy-weight just extraction the
> > ff_msmp4_mb_i_vlc initialization into a separate function would be
> > possible, too.
> Any solution is fine with me (but pick the best one if you can ;).
There is no "best", it depends on which constraints you have.
Calling the function writes to about 30 kB of .bss more than really
necessary, but given the overall space usage of VC1 decoding I don't
consider that worth e.g. adding another function (not that I have a
strong opinion on it).
So applied as-is.
More information about the ffmpeg-devel