[FFmpeg-devel] [PATCH] another stab at improved dv probe

Reimar Döffinger Reimar.Doeffinger
Sat Sep 26 18:30:56 CEST 2009

On Sat, Sep 26, 2009 at 06:34:06PM +0300, Maksym Veremeyenko wrote:
> Reimar D?ffinger ???????(??):
> >Hello,
> >another attempt at dv probe. It is still on the simple side, checking
> >that the distance between the section header difs is exactly 12000 bytes
> >or also checking the video header difs etc. is possible, but currently I
> >am still going for "as stupid as I can get away with".
> [...]
> Why do not check for DIF sequence integrity instead of some _magic bytes_?

Uh, those "magic bytes" are the DIF header, so what you propose would include
this check and just add more code. I don't mind someone doing it, but I won't
add extra code if I don't have to.

> Where are at least 10 DIF sequences for ONE frame...

Which is basically what my patch checks, though it does not care about order,
distance etc.

More information about the ffmpeg-devel mailing list