[FFmpeg-devel] [PATCH] id3v2: read TXXX frames

Anton Khirnov wyskas
Mon Sep 28 15:47:26 CEST 2009

i hope this looks better.

also added a check for "TXX" frames used in id3v2.2 tags.

and i should probably mention that this patch depends on id3v2
metadata conversion table from "mp3 muxer: write all metadata" thread

On Mon, Sep 28, 2009 at 11:38 AM, Daniel Verkamp <daniel at drv.nu> wrote:
> Surely the FFMIN is not necessary at all here due to dst[dstlen] = 0
> just previously... if the string is shorter than dstlen - 1, then the
> strlen() result will be used, and the only other possible case is
> strlen(dst) == dstlen - 1, so just
> ?val = dst + strlen(dst) + 1
> should be enough.

unless i'm missing something, there's exactly dstlen bytes between
dst[0] and dst[dstlen], so strlen(dst) == dstlen in the worst case.

Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-id3v2-Export-all-text-information-frames.patch
Type: application/octet-stream
Size: 4330 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090928/8e540334/attachment.obj>

More information about the ffmpeg-devel mailing list