[FFmpeg-devel] [PATCH] flvdec start-of-frame fix

Michael Niedermayer michaelni
Thu Apr 1 02:48:16 CEST 2010

On Wed, Mar 31, 2010 at 04:49:48PM -0700, Howard Chu wrote:
> Michael Niedermayer wrote:
>> On Tue, Mar 30, 2010 at 06:42:50PM -0700, Howard Chu wrote:
>>>> Note that the did_rseek flag wouldn't even be needed if the rest of 
>>>> flvdec
>>>> always read from the start of a frame, instead of reading from the end 
>>>> of
>>>> the previous frame, as it currently does.
>> putting the url_fskip() inside the loop at the end seems cleaner to me
>> also the url_fskip() movement could be a seperate patch
> OK, patch separated, url_fskip() moved to inside the loop.

i did not realize the continue problem, thatt said the patch looks
ok assuming the regression tests pass.
If not you could try for(;;url_fskip)
which would avoid the sligtly ugly ,1 and should work with continue
pure nitpicking i know ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100401/164c4a08/attachment.pgp>

More information about the ffmpeg-devel mailing list