[FFmpeg-devel] [PATCH] flv duration
Wed Apr 7 17:28:51 CEST 2010
Michael Niedermayer wrote:
> On Tue, Apr 06, 2010 at 07:25:37PM -0700, Howard Chu wrote:
>> At this point you're talking about one line of difference. If you're OK
>> with the patch otherwise, then it would be simpler for you to just commit
>> whatever fix you think is appropriate. All of this back and forth is just
>> wasting time.
> I see nothing in this patch that is correct.
You should have said that up front and saved us both a lot of time.
> Hiding a warning about estimated bitrate&duration by explicitly setting
> the bitrate incorrectly and thus changing a "might be wrong to a is wrong"
> isnt really an improvment.
The patch sets the bitrate based on the metadata of the stream. You're saying
the metadata can't be trusted?
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
More information about the ffmpeg-devel