[FFmpeg-devel] [PATCH] move fill_filter_caches() to h264.c

Michael Niedermayer michaelni
Mon Apr 12 16:13:46 CEST 2010

On Mon, Apr 12, 2010 at 10:01:01AM +0200, Diego Biurrun wrote:
> $subject: fill_filter_caches() is only used in h264.c.  Moving it
> to that file is sensible and eliminates at least a half dozen
> annoying 'defined but not used' warnings.
> Diego

>  h264.c |  216 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  h264.h |  216 -----------------------------------------------------------------
>  2 files changed, 216 insertions(+), 216 deletions(-)
> 5b54f8efddf871e564c6d24c7c3aa280afc2730a  fill_filter_caches.diff

ok if the generated code does not change, and might even be ok if it
does change but in that case iam curious why it does

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100412/2b55ad9a/attachment.pgp>

More information about the ffmpeg-devel mailing list