[FFmpeg-devel] [PATCH] When PMT is found, we have found mpegts header information
Sat Apr 17 16:59:11 CEST 2010
On Thu, Apr 15, 2010 at 03:08:29PM +0100, M?ns Rullg?rd wrote:
> Joakim Plate <elupus at ecce.se> writes:
> > M?ns Rullg?rd <mans <at> mansr.com> writes:
> >> Baptiste Coudurier <baptiste.coudurier <at> gmail.com> writes:
> >> > On 04/11/2010 04:29 PM, elupus wrote:
> >> >> Hi,
> >> >>
> >> >> This patch avoids av_find_stream_info searching up to probesize for mpegts.
> >> >> It only needs to search until we have found PMT/PAT, after that no new
> >> >> streams should show up.
> >> >
> >> > This is wrong. Nothing prevents a new PMT from appearing during
> >> > av_find_stream_info.
> >> Nor anywhere later in the stream.
> > While i agree, should we always let av_find_stream_info search the whole
> > file to sure we find all stream??? That doesn't make sence either.
> Of course not. The correct solution would be a design allowing
> dynamic addition and removal of streams. Unfortunately, FFmpeg isn't
> designed like that.
we could add a has_ended field to AVStream that is set when a stream has ended
besides, If there is a pmt1 and later a pmt2 i would have expected the streams
prior to pmt1 to never be described in pmt2 but not pmt1. But iam just
guessing here. If i guess correct though then it would make sense to stop
searching for new streams after pmt1 IMHO as the stream at the begin then
would have been found.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel