[FFmpeg-devel] [PATCH 2/2] Autodetect pthreads
Mon Apr 19 21:26:41 CEST 2010
Jason Garrett-Glaser <darkshikari at gmail.com> writes:
> On Mon, Apr 19, 2010 at 11:41 AM, Sebastian Vater
> <cdgs.basty at googlemail.com> wrote:
>> Hi Jason and all others!
>> Jason Garrett-Glaser a ?crit :
>>> For those who do not want or need zlib, enabling it by default will be
>>> an annoyance. ?Until you can make it read people's minds, it will
>>> always be wrong for someone.
>>> So we should disable zlib now too, right?
>>> ffmpeg should default to what the majority of users want. ?The
>>> majority of users are willing to sacrifice a few kilobytes of code for
>>> thread support. ?If you think otherwise, you are wrong.
>> It's not only this.
>> pthreads makes it impossible with at least MinGW 4.4.1 to fully
>> statically link an application, because it requires a mingw*.dll.
>> At least I was unable getting a fully statically linked executable with
>> that version (even with static pthreads).
> This is because ffmpeg refuses to add the necessary support code for
> static pthreads.
I'm refusing to fix in FFmpeg what should be fixed in pthreads-mingw.
Patches exist. I don't know if/when they'll be incorporated.
> Anyways, Mans has expressed the opinion on IRC that --enable-libx264
> shouldn't work by default. He also thinks that:
> pkg-config support should be removed (thus breaking Dirac and Schroedinger).
Correction: dirac/schroedinger should be fixed so as not to require
> Dirac should be removed too, because he doesn't like it.
Correction: I said I wouldn't object to it being removed. It's too
slow to be useful anyway.
> The defaults should never be changed, even if they are broken.
Correction: I never said anything remotely like that.
> The fact that --enable-libx264 doesn't compile correctly by default
> and results in a link error is FINE and SHOULD NOT BE FIXED.
Correction: I said the proposed patches are the wrong way to fix it.
> Furthermore, I should not be allowed to fix x264 to compile correctly
> by default.
Correction: Jason may do whatever he wants _to x264_. That does not
give him permission to change whatever he wants in FFmpeg.
> Furthermore, if I even try to fix the x264 check in configure, which
> is currently broken, he told me that he will remove my commit rights.
Correction: I'll do that if he commits something I consider incorrect.
> If he denies any of these, read the fucking logs, because he just said
> it all in a publicly logged chat.
Jason is a short-tempered teenager. Keep that in mind when reading
what he writes.
mans at mansr.com
More information about the ffmpeg-devel