[FFmpeg-devel] [PATCH] add colours to warnings and errors
Fri Apr 23 02:36:10 CEST 2010
On Thu, Apr 22, 2010 at 08:06:27PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Thu, Apr 22, 2010 at 02:14:32PM +0200, James Darnley wrote:
> >> If you can't query the background colour, then I am going to assume it
> >> is black. If your terminal isn't then you need to fix it. This is
> >> looking more and more like a Windows only feature.
> >> Yuvi suggested that I not set the bg and that I use 1 instead. For
> >> him this sets bold, for me it sets bright colours. So then there
> >> could be a terminal which has a white bg but then sets bright colours.
> >> Anyway, you guys thought it was ugly before...
> > your patch is ugly still :)
> > anyway, ive implemented it for ANSI now,
> Thanks for breaking the display on millions of consoles. You really
> need to learn how to listen to arguments other than your own.
your argument was about yellow on white, i tested it and found yellow
without the intensity/bold bit set quite readable even on white.
The actual breakage due to some terminals messing up with with ANSI codes
wasnt predicted as far as i remember. Either way the code is disabled
until we have a better way to detect ANSI support.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel