[FFmpeg-devel] [PATCH] Optimization of original IFF codec
Tue Apr 27 15:52:56 CEST 2010
On Tue, Apr 27, 2010 at 09:47:21AM -0400, Ronald S. Bultje wrote:
> Hi Michael,
> On Mon, Apr 26, 2010 at 8:18 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > benchmark of before and after this patch?
> > it adds code duplication and its not clear if it would be faster as it
> > does not change the inner loop
> Mans and I both reviewed the code and there hadn't been any comments
> since I and he first OK'ed the patch a few days ago. The code
> duplication is relatively minor and it seemed we were both OK with
> I agree ~2% isn't much, we discussed different types of optimizations
> and a more systematic approach towards this on IRC, but hey, it's 2%.
i agree that 2% justifies the change, i had not seen/realized this was
benchmarked seperate from other changes assuming it has ...
also i doubt slightly that this change truly causes a 2% speed change
absent of gcc being more stupid prior to this change. Doesnt really
matter though, faster is faster and thus better ...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Old school: Use the lowest level language in which you can solve the problem
New school: Use the highest level language in which the latest supercomputer
can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel