[FFmpeg-devel] [PATCH] add some av_unused attributes
Wed Apr 28 23:32:22 CEST 2010
On Wed, 2010-04-28 at 19:07 +0100, M?ns Rullg?rd wrote:
> Daniel Kristjansson <danielk at cuymedia.net> writes:
> > Some av_always_inline functions can cause chaff in the gcc warnings
> > because they aren't used in every c file that includes the header
> > they are in. This patch also adds "av_unused" to those six functions.
> This looks wrong. The compiler shouldn't warn about inline functions
> being unused. Did you do something unusual?
This happens when compiling MythTV's version of ffmpeg, we compile with
"-Wall -Wdisabled-optimization -Wredunant-decls -Wundef". I've been
trying to clean up the MythTV version and submit our patches upstream
so we can hopefully avoid using a patched version downstream at some
point. I didn't realize this didn't affect upstream compiles (which do
have many warnings, at least when I compile them.)
In MythTV we track warnings and try to avoid code that introduces
new ones: http://www.cuymedia.net/mythtv-warnings
A few that are known to be gcc insanity are filtered out of the
report, as well as ones that are in well maintained 3rd party
libs (so you don't see any ffmpeg warnings in our report).
More information about the ffmpeg-devel