[FFmpeg-devel] [PATCH] rtpdec_xiph: Split packets in the depacketizer

Josh Allmann joshua.allmann
Thu Aug 5 05:59:53 CEST 2010


Hi Martin,

On 4 August 2010 10:15, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Wed, Aug 4, 2010 at 7:30 AM, Martin Storsj? <martin at martin.st> wrote:
>> The xiph RTP depacketizer had an ability to output an AVPacket containing
>> many frames, if they were packed into the same RTP packet. This never
>> seemed to have been tested, and the vorbis decoder can't handle more than
>> one frame in the same AVPacket, so therefore the depacketizer should split
>> the packets, as in the attached patch.
>
> Looks OK on a quick look, let's see if Luca or Josh has more feedback,
> otherwise feel free to apply.
>

Looks good. I tried redoing this using get_buffer and related
functions to avoid all the bookkeeping for positional info, but there
doesn't seem to be a non-abusive way to do that cleanly. So it's all
OK by me.

Josh



More information about the ffmpeg-devel mailing list