[FFmpeg-devel] [PATCH] G.723.1 Decoder

[Diego Biurrun]

On Wed, Aug 04, 2010 at 08:21:33PM +0530, Mohamed Naufal wrote:
> 
> Will update Changelog, version numbers and other stuff after approval.

The patch will not be approved without them, so you are putting
yourself in a catch-22 situation.  Just add them now, it will not
take more than 15 minutes of your time.

> --- /dev/null
> +++ b/libavcodec/g723_1_data.h
> @@ -0,0 +1,1243 @@
> +/*
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */

I have no idea where this license header comes from, but it's bogus.
Use our standard license header please.

> +/**
> + * @file
> + * G723.1 compatible decoder data tables
> + */

This header is missing at least a stdint.h #include, please make sure
it passes 'make checkheaders'.

> --- /dev/null
> +++ b/libavcodec/g723_1.c
> @@ -0,0 +1,1072 @@
> +/*
> + * G.723.1 compatible decoder.

Drop the trailing period (in other places as well).

> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */

I wonder why you have used the correct header here..

> +        buf[i]     = av_clip_int16((buf[i] * (p->pf_gain + (p->pf_gain >> 4)) +
> +                                (1 << 10)) >> 11);

Indentation is off.

> --- /dev/null
> +++ b/libavformat/g723_1.c
> @@ -0,0 +1,82 @@
> +/*
> + * G.723.1 demuxer.

Ditto, drop the '.'.

Diego