[FFmpeg-devel] [PATCH] pgsdec: export base video size
Mon Aug 9 15:35:19 CEST 2010
On Mon, Aug 09, 2010 at 03:18:46PM +0200, Michael Niedermayer wrote:
> On Sun, Aug 08, 2010 at 06:45:37PM +0200, Reimar D?ffinger wrote:
> > Hello,
> > this patch would make the PGS decoder export the
> > "presentation video size" (i.e. the video dimensions
> > the coordinates are based on) in the AVCodecContext.
> > Not sure if it's that great, but it seems to work
> > fine in my quick testing hack for it in MPlayer.
> > It also has the probably purely theoretical advantage
> > that if those values are for some reason 0 in the
> > file, the decoder will use any defaults set by the user.
> > pgssubdec.c | 17 +++++++++--------
> > 1 file changed, 9 insertions(+), 8 deletions(-)
> > ae36f976c8b091a7744394009d493572e04da977 pgswh.diff
> does this have a maintainer? if not any volunteers?
Yes, I intend to take over since nobody else mentioned it.
However, I'd like to have an ok on the general idea.
Formats like DVD and DVB would accept a width/height of 0
since those are not defined or defined out-of-band for
these formats, though it would be possible to make use
of the values if set (e.g. to clip).
Though the clipping as done in the pgs decoder is rather
questionable, it might be desirable to allow placing subtitles
outside the movie area and thus it would be better for
the application to do clipping.
More information about the ffmpeg-devel