[FFmpeg-devel] [PATCH] Allow setting mode MONO in libmp3lame if the library is greater than 3.97

Måns Rullgård mans
Wed Aug 18 14:22:48 CEST 2010


Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Wednesday 2010-08-18 08:32:59 +0100, M?ns Rullg?rd encoded:
>> Tomas H?rdin <tomas.hardin at codemill.se> writes:
>> 
>> >> > ok, but this needs a configure check to make sure lame is not too old
>> >> >
>> >> >
>> >> I look at the ffmpeg configure, and i was thinking to use
>> >> check_cpp_condition, however lame does include their version in the lame.h.
>> >> The only way to get their version is to call some of their function which
>> >> return a char*.
>> >> 
>> >> so not sure how to do the check in the configure unless adding another
>> >> function specific to lame verification checking.
>> >> 
>> >> Any idea? suggestion?
>> >
>> > Couldn't you have configure create a small programs that prints that
>> > string, run it and parse and test the version number from the output?
>> 
>> No, that would fail when cross-compiling.
>
> Fix libmp3lame?
>
> But then we would only work with very recent versions of libmp3lame,
> thus breaking compilation with most distributed versions of
> libmp3lame.

Reasonably recent versions of lame work, right?  Thus no change is
needed there, and we can simply let the old ones fail.  How old is too
old anyway?

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list