[FFmpeg-devel] [PATCH 1/1] Reimplement ff_img_copy_plane() as av_img_copy_plane() in libavcore, and deprecate the old function.

[Stefano Sabatini]

On date Friday 2010-08-20 19:49:14 +0200, Stefano Sabatini encoded:
> On date Friday 2010-08-20 00:38:16 +0200, Michael Niedermayer encoded:
> > On Thu, Aug 19, 2010 at 12:54:27PM +0200, Stefano Sabatini wrote:
> > > On date Thursday 2010-08-19 12:44:34 +0200, Michael Niedermayer encoded:
> > > > On Thu, Aug 19, 2010 at 12:37:39PM +0200, Stefano Sabatini wrote:
> > > [...]
> > > > > diff --git a/libavcore/imgutils.h b/libavcore/imgutils.h
> > > > > index 874bef1..03e2e88 100644
> > > > > --- a/libavcore/imgutils.h
> > > > > +++ b/libavcore/imgutils.h
> > > > > @@ -104,4 +104,24 @@ int av_fill_image_pointers(uint8_t *data[4], enum PixelFormat pix_fmt, int heigh
> > > > >   */
> > > > >  int av_check_image_size(unsigned int w, unsigned int h, int log_offset, void *log_ctx);
> > > > >  
> > > > > +/**
> > > > > + * Copy image plane data in src_data to dst_data.
> > > > > + *
> > > > > + * @param dst_linesize linesizes for the image in dst_data
> > > > > + * @param src_linesize linesizes for the image in src_data
> > > > > + */
> > > > > +static inline
> > > > > +void av_copy_image_plane(uint8_t       *dst_data, int dst_linesize,
> > > > 
> > > > why static inline?
> > > 
> > > Should be faster, and the function looks small enough, if you prefer
> > > to keep it non-static inline I'm fine as well.
> > 
> > i prefer non static non inline
> 
> Updated.
> 
> BTW do you want to remove the static inline to
> av_fill_image_max_pixsteps() as well?

Ping.
-- 
FFmpeg = Formidable & Forgiving Magical Proud Evangelical Gadget