[FFmpeg-devel] [PATCH] Remove global mm_flags variable

Jason Garrett-Glaser darkshikari
Tue Aug 24 21:55:21 CEST 2010


On Tue, Aug 24, 2010 at 3:44 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Aug 24, 2010 at 10:39:30PM +0300, Ivan Kalvachev wrote:
>> On 8/24/10, Mans Rullgard <mans at mansr.com> wrote:
>> > -
>> > -#define emms_c() \
>> > -{\
>> > - ? ?if (mm_flags & FF_MM_MMX)\
>> > - ? ? ? ?emms();\
>> > -}
>> > +#define emms_c() emms()
>>
>> Michael, are you really OK with that change?
>> The result would be illegal instruction on all pre-MMX CPUs.
>
> who still uses these?
> and how much pre mmx x86 asm do we have?

I'm pretty sure the answer to that is "none" unless you count a bswap inline...

Dark Shikari



More information about the ffmpeg-devel mailing list