[FFmpeg-devel] [PATCH] move diag4 VP6 filter from DSPContext to VP56DSPContext

Aurelien Jacobs aurel
Wed Aug 25 00:05:52 CEST 2010


On Tue, Aug 24, 2010 at 09:58:55PM +0100, M?ns Rullg?rd wrote:
> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
> 
> > Hi,
> >
> > 2010/8/24 M?ns Rullg?rd <mans at mansr.com>:
> >> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
> >>> 2010/8/24 M?ns Rullg?rd <mans at mansr.com>:
> >>>> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
> >>>>> part of the "let's make dsputil smaller" department. make
> >>>>> fate-ea-vp60, fate-vp6a and fate-vp5 pass after this patch on OSX.
> >>>>>
> >>>>> Ronald
> >>>>>
> >>>>> Index: libavcodec/x86/Makefile
> >>>>> ===================================================================
> >>>>> --- libavcodec/x86/Makefile ? (revision 24909)
> >>>>> +++ libavcodec/x86/Makefile ? (working copy)
> >>>>> @@ -29,11 +29,13 @@
> >>>>> ?MMX-OBJS-$(CONFIG_VP3_DECODER) ? ? ? ? += x86/vp3dsp_mmx.o ? ? ? ? ? ? ?\
> >>>>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/vp3dsp_sse2.o
> >>>>> ?MMX-OBJS-$(CONFIG_VP5_DECODER) ? ? ? ? += x86/vp3dsp_mmx.o ? ? ? ? ? ? ?\
> >>>>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/vp3dsp_sse2.o
> >>>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/vp3dsp_sse2.o ? ? ? ? ? ? \
> >>>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/vp56dsp-init.o
> >>>>> ?MMX-OBJS-$(CONFIG_VP6_DECODER) ? ? ? ? += x86/vp3dsp_mmx.o ? ? ? ? ? ? ?\
> >>>>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/vp3dsp_sse2.o ? ? ? ? ? ? \
> >>>>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/vp6dsp_mmx.o ? ? ? ? ? ? ?\
> >>>>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/vp6dsp_sse2.o
> >>>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/vp6dsp_sse2.o ? ? ? ? ? ? \
> >>>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/vp56dsp-init.o
> >>>>
> >>>> Please use _ rather than - in filenames. ?There's no actual advantage
> >>>> one way or the other, but I like consistency. ?Also, that file is
> >>>> missing from the patch.
> >>>
> >>> Oops, corrected here. I'll rename _ to - in a bit, was working on
> >>> something else...
> >>
> >> OK with me, assuming you meant "- to _" there.
> >
> > Why don't I submit a patch instead of stumbling around with words... ;-).
> 
> No more comments from me.

Looks OK to me too.

Aurel



More information about the ffmpeg-devel mailing list