[FFmpeg-devel] [PATCH] Add libavsequencer.

[Sebastian Vater]

M?ns Rullg?rd a ?crit :
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>
>   
>> On date Wednesday 2010-08-25 00:55:04 +0200, Sebastian Vater encoded:
>> [...]
>>     
>>> --- /dev/null
>>> +++ b/libavsequencer/avsequencer.h
>>> @@ -0,0 +1,54 @@
>>> +/*
>>> + * AVSequencer main header file which connects to AVFormat and AVCodec
>>> + * Copyright (c) 2010 Sebastian Vater <cdgs.basty at googlemail.com>
>>> + *
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; either
>>> + * version 2.1 of the License, or (at your option) any later version.
>>> + *
>>> + * FFmpeg is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>> + * Lesser General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU Lesser General Public
>>> + * License along with FFmpeg; if not, write to the Free Software
>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>>> + */
>>> +
>>> +#ifndef AVSEQUENCER_AVSEQUENCER_H
>>> +#define AVSEQUENCER_AVSEQUENCER_H
>>> +
>>> +#define LIBAVSEQUENCER_VERSION_MAJOR 0
>>> +#define LIBAVSEQUENCER_VERSION_MINOR 0
>>> +#define LIBAVSEQUENCER_VERSION_MICRO 0
>>> +
>>> +#define LIBAVSEQUENCER_VERSION_INT AV_VERSION_INT(LIBAVSEQUENCER_VERSION_MAJOR, \
>>> +                                                  LIBAVSEQUENCER_VERSION_MINOR, \
>>> +                                                  LIBAVSEQUENCER_VERSION_MICRO)
>>> +#define LIBAVSEQUENCER_VERSION     AV_VERSION(LIBAVSEQUENCER_VERSION_MAJOR,   \
>>> +                                              LIBAVSEQUENCER_VERSION_MINOR,   \
>>> +                                              LIBAVSEQUENCER_VERSION_MICRO)
>>> +#define LIBAVSEQUENCER_BUILD       LIBAVSEQUENCER_VERSION_INT
>>> +
>>> +#define LIBAVSEQUENCER_IDENT       "Lavsequencer" AV_STRINGIFY(LIBAVSEQUENCER_VERSION)
>>> +
>>>       
>>> +/**
>>> + * Returns LIBAVSEQUENCER_VERSION_INT constant.
>>> + */
>>> +unsigned avsequencer_version(void);
>>> +
>>> +/**
>>> + * Returns the libavsequencer build-time configuration.
>>> + */
>>> +const char *avsequencer_configuration(void);
>>> +
>>> +/**
>>> + * Returns the libavsequencer license.
>>> + */
>>> +const char *avsequencer_license(void);
>>>       
>> Returns -> Return
>>
>> Looks OK otherwise, regards.
>>     
>
> Pretty please, do not commit _anything_ related to this until a full,
> functional set of patches has been presented and reviewed by several
> people.
>
>   

Hi Mans, I understand your point, but currently a) libavsequencer is
disabled by default and b) is tagged as experimental.

If I remember correctly, libavfilter got a similar way to get into SVN.

So I don't really see any big issues not commiting that part already.
But maybe I'm missing sth. out?

-- 

Best regards,
                   :-) Basty/CDGS (-: