[FFmpeg-devel] [PATCH] Add support for sndio to libavdevice
Thu Aug 26 08:43:09 CEST 2010
On 08/26/2010 01:31 AM, Stefano Sabatini wrote:
>>>> Updated to use an underscore for the filenames.
>>> Is there anything else?
>> No one seems to have any other issues with the code. What is left to get it
> I suppose an OK from Michael or from Luca Abeni (libavdevice
Well, I did not know that my OK is needed for adding a new input or output
Anyway, I had a look at the patch, assuming that this is the latest version:
The only issue I can see is the wrong computation of the input timestamp
in audio_read_packet() (BTW, what is "bdelay" used for?). If the API has
no way to return timestamps for the samples, the av_gettime() value should
be at least corrected (BTW, I seem to remember we have a timestamp filter
for this? Has it been committed?).
If this issue is fixed, I am ok with the patch, but Michael's concerns
have to be addressed before committing.
More information about the ffmpeg-devel