[FFmpeg-devel] [PATCH] Remove duplicate emms_c() calls

David Conrad lessen42
Fri Aug 27 00:06:23 CEST 2010


On Aug 26, 2010, at 6:01 PM, Alex Converse wrote:

> The following calls to emms_c() appear to be unnecessary. They all seem to
> duplicate the post video decode/encode emms call.
> 
> I verified that nothing breaks with "./configure --enable-gpl --disable-sse
> --extra-cflags=-m32 --extra-ldflags=-m32"

> Index: libavcodec/vp3.c
> ===================================================================
> --- libavcodec/vp3.c	(revision 24952)
> +++ libavcodec/vp3.c	(working copy)
> @@ -1336,7 +1336,6 @@
>      offset[2] = s->current_frame.linesize[2]*cy;
>      offset[3] = 0;
>  
> -    emms_c();
>      s->avctx->draw_horiz_band(s->avctx, &s->current_frame, offset, y, 3, h);
>      s->last_slice_end= y + h;
>  }

This (and the others like it) is needed; draw_horiz_band may be a user callback and thus use float.



More information about the ffmpeg-devel mailing list