[FFmpeg-devel] [PATCH] RTP depacketizer for QCELP

Ronald S. Bultje rsbultje
Wed Dec 1 17:41:57 CET 2010


Hi,

On Wed, Dec 1, 2010 at 11:40 AM, Reynaldo H. Verdejo Pinochet
<reynaldo at opendot.cl> wrote:
> Hi
>
> On 12/01/2010 07:32 AM, Martin Storsj? wrote:
> [...]
>>>> +static PayloadContext *qcelp_new_context(void)
>>>> +{
>>>> + ? ?return av_mallocz(sizeof(PayloadContext));
>>>> +}
>>>> +
>>>> +static void qcelp_free_context(PayloadContext *data)
>>>> +{
>>>> + ? ?av_free(data);
>>>> +}
>>>
>>> Dunno what others might think but I'd just use av_mallocz/av_free
>>> when needed.
>>
>> Uhm, could you repeat this, a bit more verbosely? I don't really
>> understand what the issue here would be.
>
> Sure, those functions serve no purpose but to wrap av_free/av_mallocz
> hence I'd just call av_free/av_mallocz directly and avoid the needles
> wrapping.

They are function pointers set in a context and called from rtsp.c.

Ronald



More information about the ffmpeg-devel mailing list