[FFmpeg-devel] [RCF] lavfi aspect ratio setting path

[Michael Niedermayer]

On Mon, Nov 29, 2010 at 03:26:40AM -0800, Baptiste Coudurier wrote:
[...]
> @@ -419,6 +430,10 @@
>  
>      codec->width  = ist->output_video_filter->inputs[0]->w;
>      codec->height = ist->output_video_filter->inputs[0]->h;
> +    ost->st->sample_aspect_ratio = codec->sample_aspect_ratio =

> +        frame_aspect_ratio == 0 ? // overriden by the -aspect cli option
> +        av_d2q(frame_aspect_ratio*codec->height/codec->width, 255) :
> +        ist->output_video_filter->inputs[0]->sample_aspect_ratio;

that looks odd if frame_aspect_ratio == 0 then
 av_d2q(frame_aspect_ratio*codec->height/codec->width, 255)
 will be used
 but thats av_d2q(0*codec->height/codec->width, 255)=0

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101203/c04be20c/attachment.pgp>