[FFmpeg-devel] [PATCH] fix seek in particular ASF file

Stefan Gehrer stefan.gehrer
Fri Dec 3 08:54:36 CET 2010

On 11/30/2010 01:35 AM, Michael Niedermayer wrote:
> On Tue, Nov 23, 2010 at 10:44:03PM +0100, Stefan Gehrer wrote:
>> Hi,
>> attached patch fixes seeking in a particular ASF file I have
>> but unfortunately can not share.
>> The ASF spec specifically mentions that non-standard
>> top-level objects as well as the 'Index Object' go between
>> the 'Data Object' and the 'Simple Index Object', but in contrast
>> in asf_build_simple_index the assumption seems to be that the
>> 'Simple Index Object' follows immediately after the 'Data Object'.
>> The file I have has an 'Index Object' in that position which
>> is skipped with this patch, making the file seekable.
>> Stefan
>>   asfdec.c |   15 ++++++++++++++-
>>   1 file changed, 14 insertions(+), 1 deletion(-)
>> ebc53d12b4cde282e6bfbe076120eed4dd048bda  asfdec_seekfix.patch
> lgtm

Thanks, applied.

The code block after that now is unconditional. Do you want me to
decrease the indention level and move the variable declarations
to the top of the function?


More information about the ffmpeg-devel mailing list