[FFmpeg-devel] port mplayer eq filter to libavfilter
Sat Dec 4 23:46:13 CET 2010
On Sat, Dec 04, 2010 at 04:01:35PM -0500, Ronald S. Bultje wrote:
> >> > + ? ? ? ?: "+r" (line), "+m" (h)
> >> > + ? ? ? ?: "r" (w), "r" (brightness), "r" (contrast), "m" (step)
> >> > + ? ? ? ?: "%"REG_c, "%"REG_d, "%"REG_a, "memory"
> >> this has some potential to fail on some x86_32 compilers
> > if it does fail it can likely be solved by putting the code under #if HAVE_7REGS
> Given that the code did not compile under x86-64, I think he tested on
> x86-32 and thus it should be ok. I can test on OSX if you're scared,
> but that's what FATE is for no? :-).
I'm certain nobody tested all compilers, and I am almost certain that
HAVE_7REGS will _not_ work for this, in the worst case
(particularly with PIC) there is a good chance this would need 9 registers.
More information about the ffmpeg-devel