[FFmpeg-devel] [PATCH] Port gradfun to libavfilter (GCI)

[Loren Merritt]

On Sun, 5 Dec 2010, Nolan L wrote:
> On Sat, Dec 4, 2010 at 12:34 PM, Stefano Sabatini wrote:
>
>> This looks weird, you're putting in outlink->out_buf a reference to
>> the input buffer, then you're doing inplace processing in end_frame().
>>
>> Is this really wanted? (and is this the behavior of the original
>> filter?).
>>
>> If this is the case you can simplify below since you don't need a
>> distinct inpic and outpic.
>
> This was basically the behavior of the original, as I understood it.
> However, it did retain the distinction between inpic and outpic. I am
> hesitant to change code that already works, partially because it may involve
> rewriting some asm functions.
>
> I will however remove the else clause of the if, as it would be impossible
> to have the two be inequal.

Then it sounds like you didn't port the MPlayer behaviour correctly. The 
MPlayer filter supported out==in if in is writable, and it also supported 
out!=in if in is read-only.

>> Is it correct to skip MMX- in OBJS?
>>
>> If MMX is disabled then this shouldn't be linked.
>
> Technically, the object file contains MMX2, SSE2, and SSSE4 methods, so I
> think it still might need to be compiled in the event that only MMX is
> disabled.

ffmpeg doesn't support disabling MMX without disabling SSE*.

--Loren Merritt