[FFmpeg-devel] port mplayer eq filter to libavfilter

[Stefano Sabatini]

On date Tuesday 2010-12-07 10:00:26 +0800, William Yu encoded:
> 2010/12/4 Michael Niedermayer <michaelni at gmx.at>:
> > On Fri, Dec 03, 2010 at 02:47:58AM +0100, Michael Niedermayer wrote:
> > [...]
> >>
> >> > +
> >> > + ? ?__asm__ volatile (
> >> > + ? ? ? ?"movd %3, %%mm3 \n\t"
> >> > + ? ? ? ?"movd %4, %%mm4 \n\t"
> >> > + ? ? ? ?"punpcklwd %%mm3, %%mm3 \n\t"
> >> > + ? ? ? ?"punpcklwd %%mm4, %%mm4 \n\t"
> >> > + ? ? ? ?"punpckldq %%mm3, %%mm3 \n\t"
> >> > + ? ? ? ?"punpckldq %%mm4, %%mm4 \n\t"
> >> > + ? ? ? ?"1: \n\t"
> >> > + ? ? ? ?"pxor %%mm0, %%mm0 \n\t"
> >> > + ? ? ? ?"mov %2, %%"REG_c" \n\t"
> >> > + ? ? ? ?"sar $3, %%"REG_c" \n\t"
> >> > + ? ? ? ?"2: \n\t"
> >> > + ? ? ? ?"movq (%0), %%mm1 \n\t"
> >>
> >> > + ? ? ? ?"movq %%mm1, %%mm2 \n\t"
> >>
> >> have you benchmarked changeing this one from mplayer?
> >
> > note, you can trivially benchmark code by putting START/STOP_TIMER around
> > code that you want to benchmark
> >
> 
> Thanks for your help. I optimizing it.
> Should i revert assembly code to original mplayer code
> before i can finding out a better way?

Absolutely.

Please try to change the code as little as you can, this is a *port*,
further optimizations can be done later (that also means less work for
you and for the reviewers).
-- 
FFmpeg = Friendly Fantastic Miracolous Proud Eager Gymnast