[FFmpeg-devel] [PATCH] libvpxenc: avoid rollover in settings conversion

Michael Niedermayer michaelni
Sat Dec 11 21:21:37 CET 2010


On Sat, Dec 11, 2010 at 12:12:25PM -0800, James Zern wrote:
> When converting bitrate values to percentages or buffer sizes to
> milliseconds as required for libvpx avoid rolling over integer values
> by using 64-bit math.
> In these cases output quality would have been adversely effected. As
> an example '-vb 2.2M -maxrate 22M' will roll
> rc_2pass_vbr_maxsection_pct (visible with -loglevel debug).
> ---
>  libavcodec/libvpxenc.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)

>  libvpxenc.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 8b6909a569c1a9b69bb1fced0b9205c3d36340a3  libvpxenc-fix_sdk_parameter_conversion.diff

lgtm

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101211/f8286887/attachment.pgp>



More information about the ffmpeg-devel mailing list