[FFmpeg-devel] [PATCH] configure: accept commercially-licensed libx264

[Ramiro Polla]

On Tue, Dec 7, 2010 at 6:11 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Tue, Dec 07, 2010 at 11:24:44AM -0200, Ramiro Polla wrote:
>> libx264 can be built with --disable-gpl, to be used with a commercial
>> license, which will export X264_GPL as 0 in their config file.
>> Attached patch makes configure accept that.
>
> I think
> X264_GPL == 0
> is true even if X264_GPL is undefined.
> If I am right about that I'd be in favour of e.g.
> defined(X264_GPL) && !X264_GPL
> instead.

Indeed it wasn't right...

So far we have:
Carl prefers if users patch ffmpeg themselves.
Ronald says commercial libx264 should be treated identically to faac.
Alex agrees with Ronald.
Reimar sees no legal issue, and thinks it's a reasonable change
(although ugly in its current state).
Baptiste also thinks it's reasonable.

It took me a while to understand why Ronald was against it, but I
think I get it now, and my patch was missing some cases. If x264 is
commercially licensed, then it should not be linked with GPL ffmpeg,
and in that case it should be treated identically as faac. But it
should be ok with LGPL ffmpeg.

New patch attached takes both cases into account.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264_gpl_3.diff
Type: application/octet-stream
Size: 1386 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101213/baaecd5c/attachment.obj>