[FFmpeg-devel] [PATCH] Add av_file_get_size() and av_file_read(), replace cmdutils.h:read_file().
Tue Dec 14 23:52:31 CET 2010
On date Tuesday 2010-12-14 23:18:52 +0100, Michael Niedermayer encoded:
> On Tue, Dec 14, 2010 at 01:48:52AM +0100, Stefano Sabatini wrote:
> > New try:
> > int av_file_map(const char *filename, uint8_t **bufptr, size_t *size, int log_offset, void *log_ctx);
> > void av_file_unmap(uint8_t *bufptr, size_t size);
> > this will simply achieve to create a writable buffer from the content
> > of the file, buffer which will be completely decoupled from the file
> > itself (that is: mmapped with MAP_PRIVATE), and which is closed before
> > returning from av_file_map(), so there is no need to keep the filedes
> > around anymore.
> > And if you don't like this design please *give more detailed
> > indications* so we'll avoid to go around in circles and waste precious
> > time and energy.
> this is ok for private (ff_) API
> for public API use of av_log() should be droped otherwise it is too
> inconvenient to use in applications that dont use av_log() already.
what's the problem with:
ret = av_file_map(filename, &buf, &size, log_offset, NULL);
FFmpeg = Friendly & Fundamentalist Mastodontic Portable Elfic Geisha
More information about the ffmpeg-devel