[FFmpeg-devel] [PATCH] add ivf muxer
Sat Dec 18 14:24:04 CET 2010
On Tue, Dec 14, 2010 at 12:18:12PM -0800, James Zern wrote:
> On Tue, Dec 14, 2010 at 11:23, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> > On Tue, Dec 14, 2010 at 10:24:06AM +0100, Tomas H?rdin wrote:
> >> On Mon, 2010-12-13 at 20:44 +0100, Reimar D?ffinger wrote:
> > [...]
> >> > + ? ?put_le64(pb, s->streams->duration); // TODO: duration or
> >> > number of frames?!?
> >> This sort of depends on whether VP8/IVF supports VFR, right? The demuxer
> >> doesn't give many hints, but with CFR you'll have duration == number of
> >> frames. Hm.
> > Which means it does not at all depend on whether it supports VFR.
> > If it doesn't it is as you said completely irrelevant, so going with
> > this (simpler) solution is perfectly fine.
> > My assumption is though that it does.
> I think this was meant to be a frame count.
Does anyone have strong objections if I use the duration anyway?
That's simpler, matches our demuxer, and I am not aware of any
application that _relies_ on that value...
Otherwise I intend to apply this soon.
More information about the ffmpeg-devel