[FFmpeg-devel] [RFC] Negative Bitrate Assertion Error
Mon Dec 20 10:42:28 CET 2010
On Sun, Dec 19, 2010 at 12:24:50PM -0800, David Czech wrote:
> >> - bit_rate += st->codec->bit_rate;
> >> + bit_rate += st->codec->bit_rate;
> >Most people here believe that not re-indenting this line makes the patch
> I don't think I understand, I should keep the if and the code on the same
> indent level? I see other if statements in a similar style
> (utils.c:1858-1861) But here it is anyway...
> >And trailing white-space cannot be committed to svn, please consider using
> Ran patcheck, tells me I need a changelog entry (but I think this is a minor
> OK, thanks.
> utils.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 3e7e6b6af3fbab6cd133586f7a7d768e10c779af bit_rate_3.patch
lgtm if tested
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel