[FFmpeg-devel] [PATCH] sdp: Add a framesize attribute to H263 SDP descriptions

Luca Abeni lucabe72
Mon Dec 20 14:01:05 CET 2010

Hi Martin,

On 12/20/2010 01:42 PM, Martin Storsjo wrote:
> While not mentioned in RFC 4629, this is required for H263 in
> 3GPP TS 26.234.
Is it really mandatory? I seem to remember it was optional...
But I might be wrong.

Anyway, I think we already discussed this some time ago...
I think setting framesize in this way is not correct (it should
be the maximum possible frame size in the session).

I am not against this patch, but I believe that a comment
is needed to explain that this code is not 100% correct, and
why this is better than nothing (mentioning the Android and
Samsung phones).


More information about the ffmpeg-devel mailing list