[FFmpeg-devel] [PATCH] av_find_best_stream

Nicolas George nicolas.george
Tue Dec 21 19:46:03 CET 2010

Thanks for the review.

Le primidi 1er niv?se, an CCXIX, Stefano Sabatini a ?crit?:
> Nit: missing empty line before @param;


>					 also I suggest fmtctx or avctx

On principle, I agree, but most surrounding functions use ic or s:
consistency seems more important.

> and no need for the ending point (no complete sentence)


> -1 for enabling automatic selection I suppose


> I'd put this into the main description, since this affects the
> function behavior.


> defied -> defined, also skip the trailing dot


Here is the updated version.

Also, correct me if I am wrong, it requires a bump of lavf minor.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-findstream-20101219-1415-01-findstream.diff
Type: text/x-diff
Size: 6234 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101221/5629ae8a/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101221/5629ae8a/attachment.pgp>

More information about the ffmpeg-devel mailing list