[FFmpeg-devel] [PATCH] Add av_file_get_size() and av_file_read(), replace cmdutils.h:read_file().

Stefano Sabatini stefano.sabatini-lala
Wed Dec 22 15:11:36 CET 2010


On date Tuesday 2010-12-21 01:20:30 +0100, Michael Niedermayer encoded:
> On Mon, Dec 20, 2010 at 10:50:28AM +0100, Stefano Sabatini wrote:
[...]
> > The problem is that the external function doesn't know the context of
> > where the error occurred, and an error code is not enough, for example
> > to distinguish if the error occurred in open(), lstat(), mmap() or if
> > the file was too big (in this case an AVERROR(EINVAL) error code
> > doesn't give a clue about the exact failure reason).
> 
> printing an error message does not affect the insufficiency (or maybe rather
> the nitpicking on that) of the error codes that are returned.
> 
> anyway feel free to commit the patch if tested

Applied.
-- 
FFmpeg = Frightening and Fantastic Mere Pitiless Everlasting Gigant



More information about the ffmpeg-devel mailing list