[FFmpeg-devel] [PATCH 4/4] Add floating-point support to the AC-3 encoder.

[Michael Niedermayer]

On Thu, Dec 23, 2010 at 04:26:01PM -0500, Justin Ruggles wrote:
> On 12/23/2010 04:07 PM, Michael Niedermayer wrote:
> 
> > On Wed, Dec 22, 2010 at 09:30:37AM -0500, Justin Ruggles wrote:
> >> +#if CONFIG_AC3ENC_FLOAT
> >> +#include "ac3enc_float.h"
> >> +#else
> >>  #include "ac3enc_fixed.h"
> >> +#endif
> > 
> > if its one or the other but not both then regression tests will become hard
> > i think the way its done with mp3 is more flexible
> 
> 
> We don't have an mp3 encoder.  The mp2 encoder has USE_FLOATS defined in
> the file directly, not by configure.  Is that what you're referring to?
> 
> Or do you mean to model it on the mp3 decoder, which has 2 separate
> decoders?

yes


> And in this case register the ac3 float encoder first to give
> it priority over the fixed encoder.  But explicitly use the fixed
> encoder for the regression tests?

you can test both in reg tests
(fix would test both encoder and decoder output, float just decoder output
 that is float encoder -> decoder -> fuzzy compare)



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101225/e4d287c2/attachment.pgp>