[FFmpeg-devel] [PATCH] VP8 EMU_EDGE support

Michael Niedermayer michaelni
Mon Dec 27 02:07:33 CET 2010

On Sat, Dec 25, 2010 at 11:35:09AM -0500, Ronald S. Bultje wrote:
> Hi,
> On Sat, Dec 25, 2010 at 10:09 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > patch adds support for that. Complications are that as far as I can
> > see, there's no restrictions on referencing off-screen pixels, in fact
> > these are defined (127/129), so I had to add some hacks to handle
> > that. Please review and let's discuss if these are acceptable or if we
> > want other ways to accomplish the same. I've added two new intra
> > prediction modes, DC_127 and DC_129, which are identical to DC_128 but
> > different value. For more comples VP8 edge intra pred cases where it
> > depends on off-frame pixels, I emulate the edge in a temp 5x8 buffer.
> > I can add more hacky intra pred cases for this but I don't think it's
> > important, after all the number of MBs that reference off-frame pixel
> > data is merely one row + one col...
> >
> > Make fate-vp8 fails with -flags emu_edge. I think this isn't because
> > displayed data output changes, because diff says PNGs are identical
> > before/after. Maybe framemd5 includes edge pixels in its pixel data?
> > Also, pixel data looks visually identical and photoshop difference
> > mask shows no differences.
> Correction: the no-pixel-diff was b/c I misplaced -flags emu_edge in
> the commandline while debugging this. Attached patch makes fate-vp8
> pass with -flags emu_edge added.
> Ronald

>  h264pred.c |   68 +++++++++++++++++++++++-
>  h264pred.h |   12 +++-

ok if needed

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101227/cfd068c4/attachment.pgp>

More information about the ffmpeg-devel mailing list