[FFmpeg-devel] [PATCH] dca: export profile information on decode
Wed Dec 29 09:01:09 CET 2010
On 29 December 2010 06:24, Anssi Hannula <anssi.hannula at iki.fi> wrote:
> While waiting for that another opinion, here's another take on the
> patch, this time with a more noticiable separation of the HD parser.
> Does this one look better?
Indeed it does look nice, if Benjamin agrees he can apply it (I simply
can't do that now).
> Instead of only checking the first asset, I simply ignore the HD part
> if it contains multiple assets or audio or has non-zero substream
> index (what do these latter two even mean?). I did this mainly because
> I'm not sure how the bitmasks that reside after num_assets behave when
> substream index / num_assets / num_audio changes, and I don't know the
> exact meanings of those variables.
yes, HD part is major PITA to implement correctly
More information about the ffmpeg-devel