[FFmpeg-devel] [PATCH] Fix a couple of errors with bad Vorbis headers

[Michael Niedermayer]

On Thu, Dec 30, 2010 at 01:05:15PM +0100, Reimar D?ffinger wrote:
> On Thu, Dec 30, 2010 at 01:13:10AM +0100, Michael Niedermayer wrote:
> > On Wed, Dec 29, 2010 at 04:58:27PM +0100, Reimar D?ffinger wrote:
> > > On Wed, Dec 29, 2010 at 03:32:20AM -0500, Gregory Maxwell wrote:
> > > > On Tue, Dec 28, 2010 at 11:19 PM, Alex Converse <alex.converse at gmail.com> wrote:
> > > > > Patch by Chris Evans/Google Chrome
> > > > >
> > > > > Chrome review URL:
> > > > > http://codereview.chromiumcodereview.org/5964011<http://codereview.chromium.org/5964011>
> > > > > Chrome bug URL:
> > > > > http://code.google.com/p/chromium/issues/detail?id=68815(Broken?)
> > > > 
> > > > I was going to test this patch to validate that it doesn't break any
> > > > regular files, but I found that a current ffmpeg git checkout
> > > > (3f9de618) doesn't play all the files in the public test vectors:
> > > > 
> > > > http://people.xiph.org/~xiphmont/test-vectors/vorbis/one-entry-codebook-test.ogg
> > > > http://people.xiph.org/~xiphmont/test-vectors/vorbis/test-short.ogg
> > > 
> > > one-entry codebooks are not supported (I am not sure our VLC reader
> > > supports "empty" VLC codes, if it doesn't that might be quite a pain to
> > > add).
> > 
> > what do you mean by empty vlc code?
> 
> Reads 0 bits, returns constant value.

get_bits_long() should be able to do this, if not it can be fixed by adding a
if(len)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101230/e68f9f04/attachment.pgp>