[FFmpeg-devel] [PATCH] avi metadata conv table

[Michael Niedermayer]

On Sat, Feb 06, 2010 at 04:33:44AM +0100, Anton Khirnov wrote:
> On Fri, Feb 05, 2010 at 09:55:09PM +0100, Michael Niedermayer wrote:
> > 
> > does this actually work?
> > i mean titles for the file ->INAM and for streams strn ?
> 
> hrm, you got me there -- it seems to be impossible without some changes
> in the metadata conversion system. i've added a workaround and a fixme
> for now.

such issues would be more noticeable if ffmpeg.c did copy all that metadata..

[...]
> @@ -378,13 +372,13 @@ static int avi_write_header(AVFormatContext *s)
>  
>      list2 = ff_start_tag(pb, "LIST");
>      put_tag(pb, "INFO");
> -    avi_write_info_tag2(s, NULL, "INAM", "Title", NULL);
> -    avi_write_info_tag2(s, NULL, "IART", "Artist", "Author");
> -    avi_write_info_tag2(s, NULL, "ICOP", "Copyright", NULL);
> -    avi_write_info_tag2(s, NULL, "ICMT", "Comment", NULL);
> -    avi_write_info_tag2(s, NULL, "IPRD", "Album", NULL);
> -    avi_write_info_tag2(s, NULL, "IGNR", "Genre", NULL);
> -    avi_write_info_tag2(s, NULL, "IPRT", "Track", NULL);
> +    while ((t = av_metadata_get(s->metadata, "", t, AV_METADATA_IGNORE_SUFFIX))) {
> +        for (i = 0; *ff_avi_tags[i]; i++)
> +            if (AV_RB32(t->key) == AV_RB32(ff_avi_tags[i])) {

will that match key = "INAMORATA" and store that as INAM ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100206/9584bf8f/attachment.pgp>