[FFmpeg-devel] [PATCH] avoid floating point for -t endtime
Sat Feb 6 17:25:50 CET 2010
On Sat, Feb 06, 2010 at 04:16:20PM +0100, Reimar D?ffinger wrote:
> On Sat, Feb 06, 2010 at 03:36:14PM +0100, Michael Niedermayer wrote:
> > On Sat, Feb 06, 2010 at 02:38:27PM +0100, Reimar D?ffinger wrote:
> > > Hello,
> > > currently the roqvideo FATE test produces different results because of this.
> > > While the test needs to be changed anyway, patch below makes them give identical
> > > results.
> > > The calculation is not 100% exact since I can't multiply recording_time with
> > > anything to avoid an overflow (actually I am not sure about the av_mul_q of
> > > time_base and pts either).
> > see compare_ts() from nut.txt
> > also if we dont have such a function, it might make sense to add it to
> > libavutil
> We have, attached patch uses it after moving it to libavutil.
> (Note I will test it as soon as compilation finishes, in about 15 minutes).
Tested, seems to work, give same results as previous version and the current code
on PPC64 (x86 gives different results with current code, one frame more).
More information about the ffmpeg-devel