[FFmpeg-devel] [PATCH] WMA Voice decoder

[Ronald S. Bultje]

Hi,

On Tue, Feb 9, 2010 at 2:35 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
> Ronald S. Bultje wrote:
>> On Tue, Feb 9, 2010 at 2:13 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
>>> Ronald S. Bultje wrote:
>>>> The (repeated) pulse set in set1() is somewhere in the range pulse_off
>>>> -/+ 10 (approximately). We're forbidding pulses in the range pulse_off
>>>> +/- 16/24 in the exclusion code of set2(). So regardless of the
>>>> bitstream value for the exact position of the pulse set in set1(), the
>>>> "extra" pulses in set2() never interfere with any possible pulse in
>>>> set1().
>>>>
>>>> (Does that make sense?)
>>>
>>> Yes, but to what correspond those excluded pulses?
>>
>> They aren't single bits (excluded pulses), they're ranges of bits (as
>> documented: 16 or 24 bits at once), which is (I gather) the range
>> within set1() could theoretically have placed its pulse.
>
> Ok, now I get it. I think this deserve a comment in the code if you hadn't
> put already...

OK, I think a rename (pulse_range instead of pitch_range) is also in
order, so both done.

(Have some more of your / Reimar's comments to take care of before I
resubmit, so please be patient.)

Ronald