[FFmpeg-devel] [PATCH] improvement on r21598 ("fix stream copy")
Thu Feb 11 20:23:02 CET 2010
> Date: Wed, 10 Feb 2010 15:26:45 +0100
> From: Michael Niedermayer <michaelni at gmx.at>
> On Sun, Feb 07, 2010 at 11:58:08AM -0000, Wolfram Gloger wrote:
> > > From: Michael Niedermayer <michaelni at gmx.at>
> > >=20
> > > well, what you write is a rather terse analysis ...
> > > because really the tests should match unless predicted and real timesta=
> > > differ and of course ignoring the current rounding bug reimar is workin=
> g on
> > I think the rounding issue is orthogonal.
> > The test for pkt.pts which you added in r21598 is done for _every_
> > packet passing the main loop.
> > The test for opts_min OTOH can only hit if the predicted timestamps
> > for _all_ streams are bigger than recording time, i.e. if N packets
> > with dts+duration>recording_time have already been written.
> > So the tests do not match, one can get in a situation where only the
> > first test hits, even when all predicted timestamps equal "real"
> > timestamps.
> > > anyway, with your patch the opts_min test should be redundant and could
> > > be removed
> > That is true, "make test" does still pass for me after removing the
> > opts_min test. Let me know if you want that incorporated in the patch
> > or separately.
Ok, here goes. Changelog suggestion:
Remove recording_time check which is no longer necessary after r21687.
Passes make test on amd64.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 436 bytes
Desc: not available
More information about the ffmpeg-devel